Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export complete package names (including features) #65

Merged
merged 1 commit into from May 26, 2022
Merged

export complete package names (including features) #65

merged 1 commit into from May 26, 2022

Conversation

dimbleby
Copy link
Contributor

I have in mind a fix to python-poetry/poetry#5537 such that the packages returned by get_project_dependency_packages() include any features that ought to be installed.

Then this fix will cause those features to be included at export.

(Except for local dependencies, which I suppose would need some different fix. I don't intend to do anything about that in this MR: it's getting a touch complicated and I don't myself care about exporting requirements.txt for local dependencies).

on its own this doesn't achieve anything, further fixes in poetry must
follow to make this effective
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dimbleby
Copy link
Contributor Author

dimbleby commented May 25, 2022

The plan that I outline only works if #64 is also merged, else we fall foul of

if package not in packages:
continue
- which is what caused me to make that MR in the first place

@abn abn merged commit 235f514 into python-poetry:main May 26, 2022
@abn abn mentioned this pull request May 26, 2022
@dimbleby dimbleby deleted the extras branch May 26, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants