fix(env): catch EnvCommandError instead of CalledProcessError when de…

…tecting active python
python-poetry · Jan 21, 2023 · ed4f442 · ed4f442
1 parent 570e8b5
commit ed4f442
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/poetry/utils/env.py b/src/poetry/utils/env.py
@@ -551,7 +551,7 @@ def _detect_active_python(self) -> str | None:
             self._io.write_error_line(
                 f"Found: {executable}", verbosity=Verbosity.VERBOSE
             )
-        except CalledProcessError:
+        except EnvCommandError:
             self._io.write_error_line(
                 (
                     "Unable to detect the current active python executable. Falling"

diff --git a/tests/utils/test_env.py b/tests/utils/test_env.py
@@ -1601,3 +1601,15 @@ def test_create_venv_project_name_empty_sets_correct_prompt(
         },
         prompt="virtualenv-py3.7",
     )
+
+
+def test_fallback_on_detect_active_python(poetry: Poetry, mocker: MockerFixture):
+    m = mocker.patch(
+        "subprocess.check_output",
+        side_effect=subprocess.CalledProcessError(1, "some command"),
+    )
+    env_manager = EnvManager(poetry)
+    active_python = env_manager._detect_active_python()
+
+    assert active_python is None
+    assert m.call_count == 1