Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @generated to poetry.lock for Phabricator support #2034

Closed
2 tasks done
lovesegfault opened this issue Feb 13, 2020 · 3 comments · Fixed by #2773
Closed
2 tasks done

Add @generated to poetry.lock for Phabricator support #2034

lovesegfault opened this issue Feb 13, 2020 · 3 comments · Fixed by #2773
Labels
kind/feature Feature requests/implementations

Comments

@lovesegfault
Copy link
Contributor

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

The company I work at uses Phabricator internally, which in turn uses the @generated string to detected whether a file shouldn't be diffed due to being generated by a tool. Would it be possible to add a header with that text to poetry.lock?

I'll note that there is some precedent, at least in Rust's Cargo, to do this: rust-lang/cargo#6180
@lovesegfault lovesegfault added the kind/feature Feature requests/implementations label Feb 13, 2020
@lovesegfault
Copy link
Contributor Author

cc. @finswimmer @sdispater

@vishalkuo
Copy link
Contributor

I'd be happy to tackle this if there's no traction

@vishalkuo vishalkuo mentioned this issue Aug 5, 2020
Merged
2 tasks
neersighted pushed a commit that referenced this issue Sep 18, 2022
@vishalkuo
adds @generated to header of lockfile (#2773)
3b4ac37 
Resolves: #2034 

It's useful to both developer tools and for users to recognize the
lock file is generated. This header should achieve both.
@BlueGlassBlock BlueGlassBlock mentioned this issue Jan 12, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/feature Feature requests/implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds @generated to header of lockfile vishalkuo/poetry
2 participants
@lovesegfault @vishalkuo