-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows PyPy3 wheel builds crash due to unclosed file #3545
Closed
3 tasks done
Labels
kind/bug
Something isn't working as expected
Comments
kurtmckee
added a commit
to kurtmckee/pr-poetry-core
that referenced
this issue
Jan 7, 2021
kurtmckee
added a commit
to kurtmckee/pr-poetry-core
that referenced
this issue
Jan 7, 2021
This resolves a crash that occurs on PyPy3 on Windows Closes python-poetry/poetry#3545
2 tasks
kurtmckee
added a commit
to kurtmckee/pr-poetry-core
that referenced
this issue
Jan 7, 2021
kurtmckee
added a commit
to kurtmckee/pr-poetry-core
that referenced
this issue
Jan 7, 2021
This resolves a crash that occurs on PyPy3 on Windows Closes python-poetry/poetry#3545
brechtm
added a commit
to brechtm/rinohtype
that referenced
this issue
Jan 28, 2021
- always install tox & co using pip3.9 - additionally install the Python version to test against (if not 3.9) - this setup allows testing against Python 3.10 - map python-version to a TOXENV manually (obsoletes tox-gh-actions) - ignore failures of tests running against PyPy for now (python-poetry/poetry#3545)
brechtm
added a commit
to brechtm/rinohtype
that referenced
this issue
Jan 28, 2021
- always install tox & co using pip3.9 - additionally install the Python version to test against (if not 3.9) - this setup allows testing against Python 3.10 - map python-version to a TOXENV manually (obsoletes tox-gh-actions) - ignore failures of tests running against PyPy for now (python-poetry/poetry#3545)
brechtm
added a commit
to brechtm/rinohtype
that referenced
this issue
Jan 28, 2021
- always install tox & co using pip3.9 - additionally install the Python version to test against (if not 3.9) - this setup allows testing against Python 3.10 - map python-version to a TOXENV manually (obsoletes tox-gh-actions) - ignore failures of tests running against PyPy for now (python-poetry/poetry#3545)
brechtm
added a commit
to brechtm/rinohtype
that referenced
this issue
Jan 28, 2021
- always install tox & co using pip3.9 - additionally install the Python version to test against (if not 3.9) - this setup allows testing against Python 3.10 - map python-version to a TOXENV manually (obsoletes tox-gh-actions) - ignore failures of tests running against PyPy for now (python-poetry/poetry#3545)
brechtm
added a commit
to brechtm/rinohtype
that referenced
this issue
Jan 28, 2021
- always install tox & co using pip3.9 - additionally install the Python version to test against (if not 3.9) - this setup allows testing against Python 3.10 - map python-version to a TOXENV manually (obsoletes tox-gh-actions) - add a '-pyXY' factor to the TOXENV for the regression tests - ignore failures of tests running against PyPy for now (python-poetry/poetry#3545)
brechtm
added a commit
to brechtm/rinohtype
that referenced
this issue
Jan 28, 2021
- always install tox & co using pip3.9 - additionally install the Python version to test against (if not 3.9) - this setup allows testing against Python 3.10 - map python-version to a TOXENV manually (obsoletes tox-gh-actions) - add a '-pyXY' factor to the TOXENV for the regression tests - ignore failures of tests running against PyPy for now (python-poetry/poetry#3545)
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
-vvv
option).Issue
Poetry crashes when building wheels on Windows when using PyPy3.6 and PyPy3.7. The root cause is an unclosed file in
poetry/core/masonry/builders/wheel.py
, which causesshutil.move()
to fail with aPermissionError
. Here are the steps to reproduce. Note that I am using Powershell, so some commands may require syntax changes if you're reproducing incmd.exe
.C:\Program Files (x86)\pypy37\
.git clone https://github.com/kurtmckee/feedparser.git
cd feedparser
git checkout 727ee7f
& 'C:\Program Files (x86)\pypy37\pypy3.exe' -m venv venv-pypy37
.\venv-pypy37\Scripts\Activate.ps1
pypy3 -m pip install --upgrade pip
pypy3 -m pip install poetry
pypy3.exe
topython.exe
so Poetry can run "python":copy .\venv-pypy37\Scripts\pypy3.exe .\venv-pypy37\Scripts\python.exe
poetry update
poetry build
The output that I get is a traceback:
The root cause is an unmanaged
os.fdopen()
call inpoetry/core/masonry/builders/wheel.py
that keeps the zip file open whenshutil.move()
is called.I've already tested a fix and will submit a PR shortly.
The text was updated successfully, but these errors were encountered: