Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear that default setting of virtualenvs.in-project means that venvs are created in cache-dir #3709

Closed
1 task done
marko-galesic opened this issue Feb 20, 2021 · 4 comments · Fixed by #5656
Closed
1 task done

Unclear that default setting of virtualenvs.in-project means that venvs are created in cache-dir #3709

marko-galesic opened this issue Feb 20, 2021 · 4 comments · Fixed by #5656
Labels
area/docs Documentation issues/improvements

Comments

@marko-galesic
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.

Issue

Can something be added to the virtualenvs.in-project setting documentation that mentions that without a .venv in the project and with the default value of virtualenvs.in-project that poetry install will create a venv under the directory
in cache-dir?
@marko-galesic marko-galesic added area/docs Documentation issues/improvements status/triage This issue needs to be triaged labels Feb 20, 2021
@vmorris
Copy link

vmorris commented Mar 15, 2021

Wow thank you @tavor ... I was really scratching my head on this one.

Based on the documentation I was expecting poetry to create a .venv within my project directory if one did not exist. Very confusing!

@finswimmer
Copy link
Member

Maybe just copy the first sentence from here: https://python-poetry.org/docs/basic-usage/#using-your-virtual-environment to here: https://python-poetry.org/docs/configuration/#virtualenvsin-project-boolean ?

@Secrus
Copy link
Member

Secrus commented May 16, 2022

I think adding a short note, about the default path of virtualenvs when virtualenvs.in-project is set to false, would be enough. PRs on that are welcome.

@Secrus Secrus added Good First Issue and removed status/triage This issue needs to be triaged labels May 16, 2022
Secrus added a commit to Secrus/poetry that referenced this issue May 20, 2022
@Secrus
Changes in docs for Issues python-poetry#4800, python-poetry#3709, py…
a6d2520 
…thon-poetry#3573, python-poetry#2211, python-poetry#521 and PR python-poetry#2414

- Added section about `extras` in `dependency-specification.md` (python-poetry#2414)
- Added note about VCS inclusion and exclusion in `include`/`exclude`
sections of `pyproject.toml` (python-poetry#4800)
- Added link to dependency specification in `add` command documentation
(python-poetry#3573)
- Added more info on default behaviour and cleaned up
`virtualenv.in-project` setting documentation (python-poetry#3709)
- Added missing configuration options to `configuration.md` (python-poetry#2211)
@Secrus Secrus mentioned this issue May 20, 2022
Merged
1 task
neersighted pushed a commit that referenced this issue May 23, 2022
@Secrus @abn
Changes in docs for Issues #4800, #3709, #3573, #2211 and PR #2414 (#…
3349ba9 
…5656)

* Changes in docs for Issues #4800, #3709, #3573, #2211, #521 and PR #2414

- Added section about `extras` in `dependency-specification.md` (#2414)
- Added note about VCS inclusion and exclusion in `include`/`exclude`
sections of `pyproject.toml` (#4800)
- Added link to dependency specification in `add` command documentation
(#3573)
- Added more info on default behaviour and cleaned up
`virtualenv.in-project` setting documentation (#3709)
- Added missing configuration options to `configuration.md` (#2211)

Co-authored-by: Arun Babu Neelicattu <arun.neelicattu@gmail.com>
@abn abn mentioned this issue Jun 6, 2022
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/docs Documentation issues/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes in docs for Issues #4800, #3709, #3573, #2211 and PR #2414 Secrus/poetry
4 participants
@marko-galesic @finswimmer @vmorris @Secrus