Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.extras is not reproducible #5125

Closed
3 tasks done
ali5h opened this issue Jan 29, 2022 · 4 comments · Fixed by python-poetry/poetry-core#280
Closed
3 tasks done

package.extras is not reproducible #5125

ali5h opened this issue Jan 29, 2022 · 4 comments · Fixed by python-poetry/poetry-core#280
Labels
kind/bug Something isn't working as expected

Comments

@ali5h
Copy link

ali5h commented Jan 29, 2022

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • ubuntu 20.04
  • poetry 1.1.12
  • pyproject.toml
[tool.poetry]
name = "hdfs-test"
version = "0.1.0"
description = ""
authors = ["test"]
[tool.poetry.dependencies]
python = "^3.8"
apache-airflow = "^2.2.3"
[tool.poetry.dev-dependencies]
pytest = "^5.2"
[build-system]
requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

Issue

one of the entries in package.extras for apache-airflow in poetry.lock file is

"apache.webhdfs" = ["hdfs[dataframe,avro,kerberos] (>=2.0.4)"]

The hdfs[dataframe,avro,kerberos] part is not reproducible and on poetry update the order of its extras changes (i.e it becomes hdfs[avro,dataframe,kerberos])

@ali5h ali5h added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jan 29, 2022
@finswimmer
Copy link
Member

one of the entries in package.extras for apache-airflow is

You are talking about the resulting poetry.lock file for the pyprject.toml above?

@finswimmer finswimmer added the status/waiting-on-response Waiting on response from author label Jan 30, 2022
@ali5h
Copy link
Author

ali5h commented Jan 30, 2022

yes

@finswimmer finswimmer removed the status/waiting-on-response Waiting on response from author label Jan 31, 2022
@cpcloud
Copy link

cpcloud commented Feb 2, 2022

I think this is related to the fact that extras are stored in-memory using a frozenset, the ordering of which is arbitrary.

I also have this issue, and the current workaround isn't great: I have to set PYTHONHASHSEED when doing operations that may affect the lock file.

This makes it hard for contributors to contribute because they have to know to do this when changing things related to poetry.

@ali5h ali5h changed the title package.extras is not reporduable package.extras is not reporducable Feb 3, 2022
@ali5h ali5h changed the title package.extras is not reporducable package.extras is not reproducible Feb 3, 2022
ali5h added a commit to ali5h/poetry-core that referenced this issue Feb 3, 2022
ali5h added a commit to ali5h/poetry-core that referenced this issue Feb 3, 2022
ali5h added a commit to ali5h/poetry-core that referenced this issue Feb 3, 2022
ali5h added a commit to ali5h/poetry-core that referenced this issue Feb 3, 2022
finswimmer pushed a commit to python-poetry/poetry-core that referenced this issue Feb 4, 2022
@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
DavidVujic pushed a commit to DavidVujic/poetry-core that referenced this issue Mar 26, 2022
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this issue Aug 29, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants