marker union is non-deterministic in ordering

[dimbleby]

def test_consistent_order() -> None:
    m1 = parse_marker(
        'python_version >= "3.6" and python_version < "3.7" and python_full_version <'
        ' "3.6.2"'
    )
    m2 = parse_marker(
        'python_full_version >= "3.6.2" and python_full_version < "4.0.0" and'
        ' python_version >= "3.6" and python_version < "3.7"'
    )
    union = m1.union(m2)
    assert (
        str(union)
        == 'python_version >= "3.6" and python_version < "3.7" and python_full_version'
        ' < "4.0.0"'
    )

sometimes passes, sometimes fails.

(This testcase assumes python-poetry/poetry-core#382)

This makes it a right pain to try and write unit tests, if nothing else...

I think that the indeterminacy is introduced at MultiMarker.union_simplify(), which puts markers into a set; but iteration order on that set seems to be arbitrary.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.