Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of master branch in poetry-core on June 1, 2023 #6741

Closed
mkniewallner opened this issue Oct 7, 2022 · 2 comments
Closed

Removal of master branch in poetry-core on June 1, 2023 #6741

mkniewallner opened this issue Oct 7, 2022 · 2 comments
Labels
area/core Related to the poetry-core library impact/deprecation Introduces or relates to a deprecation

Comments

@mkniewallner
Copy link
Member

mkniewallner commented Oct 7, 2022

The main branch of poetry-core was renamed from master to main in May 2022. Since this broke some packages explicitly referencing master, it was decided to copy the main branch into master branch to not break those usages.

As master is not updated from main, and it is confusing to keep both branches around, there's no point keeping master indefinitely.

So this issue acts as a deprecation notice for usages of master branch of poetry-core, as we are planning to delete the branch on June 1, 2023.

This change will impact packages that use git references when defining poetry-core as a build-system, for instance by doing:

[build-system]
requires = ["poetry-core @ git+https://github.com/python-poetry/poetry-core.git@master"]
build-backend = "poetry.core.masonry.api"

Once master branch is removed, any package still referencing master branch as their build system will not be installable. Note that using a moving git branch for the build system on published packages is a highly discouraged practice, since:

  • update to branches could break usages at any moment, as they represent a development version of the project, and not official releases
  • branches are not immutable, and can be deleted in git

If you are a package maintainer and are referencing poetry-core by using master branch from the git repository (or any other branch, for what it's worth), it is highly recommended to update the build system of the package to rely on versions published to PyPI, for instance:

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

or, if you rely on features implemented in specific versions of poetry-core, by defining a lower bound, for instance:

[build-system]
requires = ["poetry-core>=1.2.0"]
build-backend = "poetry.core.masonry.api"
@mkniewallner mkniewallner added area/build-system Related to PEP 517 packaging (see poetry-core) area/core Related to the poetry-core library impact/deprecation Introduces or relates to a deprecation labels Oct 7, 2022
@neersighted neersighted removed the area/build-system Related to PEP 517 packaging (see poetry-core) label Oct 10, 2022
@Secrus Secrus pinned this issue Apr 27, 2023
@Secrus
Copy link
Member

Secrus commented Jun 5, 2023

The master branch in poetry-core was dropped.

@Secrus Secrus closed this as completed Jun 5, 2023
@Secrus Secrus unpinned this issue Jun 5, 2023
jeffjose added a commit to jeffjose/whenareyou that referenced this issue Jun 9, 2023
mrhorvath added a commit to wake-forest-ctsi/target-oracle that referenced this issue Jul 7, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/core Related to the poetry-core library impact/deprecation Introduces or relates to a deprecation
Projects
None yet
Development

No branches or pull requests

3 participants