Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace poetry lock --check with poetry check --lock #6756

Closed
2 tasks done
johnthagen opened this issue Oct 9, 2022 · 1 comment · Fixed by #8015
Closed
2 tasks done

Replace poetry lock --check with poetry check --lock #6756

johnthagen opened this issue Oct 9, 2022 · 1 comment · Fixed by #8015
Labels
area/cli Related to the command line area/ux Features and improvements related to the user experience impact/deprecation Introduces or relates to a deprecation status/accepted Feature request accepted for the roadmap

Comments

@johnthagen
Copy link
Contributor

johnthagen commented Oct 9, 2022

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

There is an important need for development teams to validate their Poetry configuration files and lockfile freshness in CI. This should ideally be done in a single, easy to understand command.

The following PR added poetry lock --check:

The problem is that this is a somewhat strange UI, especially given that the separate poetry check command already exists (and existed). Sebastian noted this and asked for a revert (which must never have happened?):

I propose, similar to Sebastian, that poetry lock --check be deprecated and its functionality moved to poetry check --lock. This would be easier to teach and explain to new Poetry users and would keep all "file validation logic" under poetry check.

poetry check --lock would therefor be the superset of everything that is checked in poetry check and poetry lock --check so that a user can run a single command in CI and get all validation performed.

@neersighted seemed to agree in:

@johnthagen johnthagen added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Oct 9, 2022
@neersighted neersighted added area/cli Related to the command line area/ux Features and improvements related to the user experience status/accepted Feature request accepted for the roadmap impact/deprecation Introduces or relates to a deprecation and removed kind/feature Feature requests/implementations labels Oct 10, 2022
@radoering radoering removed the status/triage This issue needs to be triaged label Jun 12, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line area/ux Features and improvements related to the user experience impact/deprecation Introduces or relates to a deprecation status/accepted Feature request accepted for the roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants