Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry check to CI #147

Closed
johnthagen opened this issue Dec 20, 2022 · 2 comments · Fixed by #158
Closed

Add poetry check to CI #147

johnthagen opened this issue Dec 20, 2022 · 2 comments · Fixed by #158
Assignees
Labels
enhancement New feature or request upstream

Comments

@johnthagen
Copy link
Owner

johnthagen commented Dec 20, 2022

It turns out that poetry lock --check only validates a subset of what poetry check validates (such as Trove classifiers).

This would be improved if the following upstream issue were completed:

Should add poetry check in addition to poetry lock --check to CI.

This is blocked however by this upstream Poetry issue:

@johnthagen johnthagen added enhancement New feature or request upstream labels Dec 20, 2022
@johnthagen
Copy link
Owner Author

was merged, so next Poetry release this should be possible to fix.

@johnthagen
Copy link
Owner Author

Poetry 1.4.0 is released, but there seems to be some issues with its installer dependency

Should wait on this before recommending Poetry 1.4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant