-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version strings in project files. (#144) #1354
Conversation
Added a dry-run option to version command and logic to replace current version strings with next version in: - pyproject.toml - python source ( assignments & comparisons ) - markdown | restructured text | plain text
I took a stab at writing tests for this new feature, but ran into trouble due to lack of familiarity with how to use/extend the fixtures already provided. I'll keep working the problem. |
This is an interesting approach, but I could see a lot of potential for false positives, in places like a changelog, or even list of requirements. What if you require a specific version of a package, which matches the version of your local package? I think a better approach might be explicit configuration of the locations of the version, such as how |
Excellent point that I had not considered.
Excellent feedback, thank you. I'm not sure how opinionated poetry wants to be about how a package is structured so my goal was to avoid specifying where version data should go. |
i think this functionality is out of |
@funkyfuture I disagree, poetry already changes the project version number in pyproject.toml, it's a small step forward to take the burden off the developer and change it in the shipping (code/docs) part of the project. |
Thanks for you contribution! However, this is beyond the intended purpose of I am closing this but that's a feature that can be implemented as a plugin when they are supported. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
#144
Added a dry-run option to version command and logic to
replace current version strings with next version in:
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based on the
develop
branch. If it's a bug fix or only a documentation update, it should be based on themaster
branch.