Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for poetry env remove when virtualenvs.in-project = true #2748

Closed
wants to merge 10 commits into from
Closed

add support for poetry env remove when virtualenvs.in-project = true #2748

wants to merge 10 commits into from

Commits on Nov 15, 2020

  1. add support for poetry env remove when virtualenvs.in-project = true 

    resolves #2124
    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    7a22d7b View commit details
    Browse the repository at this point in the history

  2. add tests

    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    745772c View commit details
    Browse the repository at this point in the history

  3. update docs to include "poetry env remove .venv"

    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    ab02541 View commit details
    Browse the repository at this point in the history

  4. remove pytest.mark.wip that was added during development

    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    c44083c View commit details
    Browse the repository at this point in the history

  5. remove python default value, split remove into smaller methods 

    - remove python default value
- split the remove method into smaller methods
- used the logic from remove to create a new method for finding an environment
- remove now uses get to delete the active venv if python is not provided
- remove now uses the new find method to located the venv to remove

TODO update existing tests and write new tests
    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    80496f3 View commit details
    Browse the repository at this point in the history

  6. fix preexisting tests, comment out my tests for the time being

    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    eec6b3c View commit details
    Browse the repository at this point in the history

  7. skip remove from env file when path name is .venv, add initial test

    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    9b2efff View commit details
    Browse the repository at this point in the history

  8. update documentation

    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    06b6024 View commit details
    Browse the repository at this point in the history

  9. rename method, add tests, update tests 

    - method name is now more accurate to its intended functionality
- add test for `env remove` command
- add tests for EnvManager.find
- update some previously added tests to use mocker instead of monkeypatch
    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    7b737c4 View commit details
    Browse the repository at this point in the history

  10. add more detail to argument description

    @ITProKyle
    ITProKyle committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    46aca34 View commit details
    Browse the repository at this point in the history