Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export: restore -e for develop exports #3118

Closed
wants to merge 4 commits into from
Closed

export: restore -e for develop exports #3118

wants to merge 4 commits into from

Conversation

mrcljx
Copy link

@mrcljx mrcljx commented Oct 7, 2020 •
edited

Pull Request Check List

The line variable containing -e was consistently overwritten.

  • Added tests for changed code.
  • Updated documentation for changed code.

@mrcljx mrcljx marked this pull request as ready for review October 7, 2020 14:17
@mrcljx mrcljx mentioned this pull request Oct 7, 2020
Closed
2 tasks
@finswimmer finswimmer requested a review from a team October 7, 2020 17:29
abn
abn requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of issues here,

  1. I am not sure if -e works well for PEP 517 directory dependencies
  2. I do not think the checks are correct for this, only directory dependencies and vcs dependencies support editable installs.

@mrcljx
Copy link
Author

mrcljx commented Oct 7, 2020

  1. I am not sure if -e works well for PEP 517 directory dependencies

Shouldn't the user then have removed develop = true?

  1. I do not think the checks are correct for this, only directory dependencies and vcs dependencies support editable installs.

Will make the change.

@mrcljx mrcljx requested a review from abn October 7, 2020 18:13
@mrcljx mrcljx marked this pull request as draft October 7, 2020 18:14
@mrcljx mrcljx marked this pull request as ready for review October 7, 2020 18:16
@abn
Copy link
Member

abn commented Oct 7, 2020

Shouldn't the user then have removed develop = true?

I guess this was existing behaviour. The the difference is poetry can handle PEP 517 packages, so a user might have develop = true set for these. Either way, since this is not changing 1.0.10 behaviour it should be okay.

abn
abn reviewed Oct 7, 2020
View reviewed changes
tests/utils/test_exporter.py Outdated
@@ -497,7 +497,7 @@ def test_exporter_can_export_requirements_txt_with_git_packages(tmp_dir, poetry)
content = f.read()

expected = """\
foo @ git+https://github.com/foo/foo.git@123456
-e foo @ git+https://github.com/foo/foo.git@123456
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, these are not marked as develop in the lock data above. This should not, be -e prefixed. I think there is a bug some place else. I wonder if python-poetry/poetry-core#98 is related?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I felt like I saw a PR for this. I can wait for that to land and then rebase my change here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you can test with that branch locally atleast to confirm this is the case. Else we will have to dig into it seperately.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that against that branch the tests don't need updating.

@mrcljx mrcljx marked this pull request as draft October 8, 2020 14:54
@mrcljx
Copy link
Author

mrcljx commented Oct 8, 2020

Converting to Draft until python-poetry/poetry-core#98 is landed.

@mrcljx mrcljx closed this May 10, 2022
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abn abn abn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrcljx @abn