Fix error in "poetry config" when Poetry is not configured in pyproject.toml (3084) #3172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finswimmer
approved these changes
Oct 11, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Good work 👍 Thanks a lot for your contribution.
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #3084
Add catch for
PyProjectExceptioninConfigCommand. I also add a test and patch thepoetry.factory.Factory.create_poetryto raise the exception...I'm not sure is the best option as I can't figure out how to create an app/poetry object with empty configuration...
Fyi this PR is related to Hacktoberfest :)