Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in "poetry config" when Poetry is not configured in pyproject.toml (3084) #3172

merged 2 commits into from Oct 11, 2020


Copy link

@estyxx estyxx commented Oct 10, 2020

Pull Request Check List

Resolves: #3084

  • Added tests for changed code.
  • Updated documentation for changed code.

Add catch forPyProjectException in ConfigCommand. I also add a test and patch the poetry.factory.Factory.create_poetry to raise the exception...
I'm not sure is the best option as I can't figure out how to create an app/poetry object with empty configuration...

Fyi this PR is related to Hacktoberfest :)

Copy link

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍 Thanks a lot for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Error in "poetry config" when Poetry is not configured in pyproject.toml
3 participants