Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: add tests to sdists #4007

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conversation

abn
Copy link
Member

@abn abn commented Apr 30, 2021

Resolves: #3952

@eli-schwartz
Copy link

Thank you! Would you be able to do the same for poetry-core too?

@kwshi
Copy link

kwshi commented Apr 30, 2021

I have opened python-poetry/poetry-core#173 implementing this. (By the way, is the format = "sdist" in the include clause needed? Based on what I can tell, even if I omitted it the tests module doesn't end up in the resulting wheel anyway.)

@sdispater sdispater merged commit a516a8f into python-poetry:master Apr 30, 2021
@abn abn deleted the sdist/include-tests branch April 30, 2021 09:36
@abn
Copy link
Member Author

abn commented Apr 30, 2021

I have opened python-poetry/poetry-core#173 implementing this. (By the way, is the format = "sdist" in the include clause needed? Based on what I can tell, even if I omitted it the tests module doesn't end up in the resulting wheel anyway.)

I would prefer that we are explicit about the intention. Hence why we specify the format.

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0.3: tests/ directory missing in idst pypy tar ball
4 participants