Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pyupgrade via pre-commit #4758

Merged
merged 2 commits into from
Nov 17, 2021
Merged

feat: pyupgrade via pre-commit #4758

merged 2 commits into from
Nov 17, 2021

Conversation

neersighted
Copy link
Member

Run pyupgrade against the whole codebase, as well as add a pyupgrade pre-commit hook to prevent obsolete syntax/imports in the future.

hooks:
- id: pyupgrade
args: [--py36-plus]
exclude: '^(install|get)-poetry.py$'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are excluded as get-poetry.py is in maintenance mode and install-poetry.py is vendored from a different repo.

neersighted and others added 2 commits November 16, 2021 18:51
Implements the reviews from #3987 and #3988. Special thanks to the
committers and reviewers there.

Co-authored-by: Harry Peach <harrypeach1999@gmail.com>
Co-authored-by: Kamyar Ghasemlou <kamyar@kamy.me>
Co-authored-by: Leonardo Freua <leonardo.batista.freua@gmail.com>
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@neersighted neersighted merged commit fd3f338 into master Nov 17, 2021
@neersighted neersighted deleted the neersighted/pyupgrade branch November 17, 2021 22:36
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants