Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type hints - Part 2 #4801

Merged

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Nov 19, 2021

This is the part 2 of incremental PR with the goal to force type hints in application code and tests.

This PR adds missing typehints to:

  • tests.inspections
  • tests.installations
  • tests.masonry
  • tests.mixology
  • tests.packages
  • tests.plugins

The conftest.py in the tests root folder will be updated whenever needed.

@finswimmer finswimmer force-pushed the improvement/force-type-hints_part-2 branch from a95115f to f527c3a Compare November 19, 2021 16:42
@finswimmer finswimmer changed the title Improvement/force type hints part 2 Add missing type hints - Part 2 Nov 19, 2021
@finswimmer finswimmer marked this pull request as ready for review November 19, 2021 20:08
@finswimmer finswimmer requested a review from a team November 19, 2021 20:08
@neersighted neersighted merged commit 5c328a3 into python-poetry:master Nov 20, 2021
edvardm pushed a commit to edvardm/poetry that referenced this pull request Nov 24, 2021
* add typehints to tests.inspection

* change several yield statements in fixtures to return

* add typehints to tests.installation.test_chef, tests.installation.test_chooser, tests.installation.test_executor

* add typehints to tests.installation.test_installer

* add typehints to tests.installation.test_installer_old

* add typehints to tests.installation.test_pip_installer

* add typehints to tests.masonry

* add typehints to tests.mixology

* add typehints to tests.packages

* add typehints to tests.plugins
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants