-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing type hints - Part 2 #4801
Merged
neersighted
merged 10 commits into
python-poetry:master
from
finswimmer:improvement/force-type-hints_part-2
Nov 20, 2021
Merged
Add missing type hints - Part 2 #4801
neersighted
merged 10 commits into
python-poetry:master
from
finswimmer:improvement/force-type-hints_part-2
Nov 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_chooser, tests.installation.test_executor
finswimmer
force-pushed
the
improvement/force-type-hints_part-2
branch
from
November 19, 2021 16:42
a95115f
to
f527c3a
Compare
finswimmer
changed the title
Improvement/force type hints part 2
Add missing type hints - Part 2
Nov 19, 2021
neersighted
approved these changes
Nov 20, 2021
edvardm
pushed a commit
to edvardm/poetry
that referenced
this pull request
Nov 24, 2021
* add typehints to tests.inspection * change several yield statements in fixtures to return * add typehints to tests.installation.test_chef, tests.installation.test_chooser, tests.installation.test_executor * add typehints to tests.installation.test_installer * add typehints to tests.installation.test_installer_old * add typehints to tests.installation.test_pip_installer * add typehints to tests.masonry * add typehints to tests.mixology * add typehints to tests.packages * add typehints to tests.plugins
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part 2 of incremental PR with the goal to force type hints in application code and tests.
This PR adds missing typehints to:
The
conftest.py
in the tests root folder will be updated whenever needed.