Add missing type hints & Force type hints - Part 3 #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finswimmer
force-pushed
the
improvement/force-type-hints_part-3
branch
from
84d1465
to
ab8a38b
Compare
finswimmer
force-pushed
the
improvement/force-type-hints_part-3
branch
from
c7d4805
to
e1a1859
Compare
finswimmer
changed the title
neersighted
requested changes
Nov 23, 2021
.flake8
Outdated
| @@ -3,6 +3,7 @@ min_python_version = 3.6.0 | |||
| max-line-length = 88 | |||
| ban-relative-imports = true | |||
| inline-quotes = double | |||
| mypy-init-return = True | |||
There was a problem hiding this comment.
Let's add a comment here explaining which plugin this corresponds to / maybe a doc link? Also let's go for a lower case true since that's what we've done in the rest of the file.
.pre-commit-config.yaml
Outdated
| @@ -41,6 +41,7 @@ repos: | |||
| - flake8-type-checking==1.1.0 | |||
| - flake8-typing-imports==1.11.0 | |||
| - pep8-naming==0.12.1 | |||
| - flake8-annotations | |||
There was a problem hiding this comment.
Let's lock this to a version and alphabetize it.
…, tests.utils.test_env_site, tests.utils.test_exporter
…ests.utils.test_password_manager, tests.utils.test_patterns, tests.utils.test_pip, tests.utils.setup_reader
finswimmer
force-pushed
the
improvement/force-type-hints_part-3
branch
from
a661bca
to
5214721
Compare
neersighted
approved these changes
Nov 23, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the final part of a series which add missing type hints to both package code and test code. Furthermore flake-annotations is added as a flake8 plugin to enforce type hints in the future.