Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(show): handle missing lockfile #5242

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

branchvincent
Copy link
Member

@branchvincent branchvincent commented Feb 27, 2022

poetry show relies on the existence of poetry.lock to display dependencies, but it currently throws a SolverProblemError if this file doesn't exist yet. This checks if the lockfile is missing and errors, if needed.

Pull Request Check List

Resolves: #5240

  • Added tests for changed code.
  • Updated documentation for changed code.

@branchvincent branchvincent changed the title fix(show): ensure lockfile exists fix(show): handle missing lockfile Feb 27, 2022
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@finswimmer finswimmer merged commit e403ff4 into python-poetry:master Feb 28, 2022
@branchvincent branchvincent deleted the fix/show-no-lockfile branch February 28, 2022 13:03
@finswimmer finswimmer mentioned this pull request Mar 6, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry show gives clickit "NoSuchOptionException(name)" error
2 participants