Allow any file extension for README file #5357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
requested changes
May 18, 2022
|
I think it would be good to add a warning or note in |
|
Deploy preview for website ready! ✅ Preview Built with commit 48bffbb. |
|
I added @neersighted's suggestion and added a sentence as suggested by @Secrus. |
neersighted
previously approved these changes
May 24, 2022
|
@s-spindler please fix the pre-commit problem so we could merge this. |
Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>
s-spindler
force-pushed
the
allow-any-readme
branch
from
ad75670
to
5be2104
Compare
Secrus
approved these changes
May 29, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #5356