Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerate poetry init in / #5612

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

dimbleby
Copy link
Contributor

Pull Request Check List

Resolves: #5103

  • Added tests for changed code.
  • Updated documentation for changed code.

Not so easy to add a testcase for this one: I can arrange that we go through the fixed code branch, but then the unit test actually tries to create a project in /, which it usually doesn't have permission to do (and would be undesirable even if it did)

@dimbleby dimbleby changed the title tolerate in tolerate poetry init in / May 15, 2022
Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throw a comment in explaining why we're checking this (maybe a link to the issue, even) and I think we're good.

@neersighted neersighted merged commit 7db3e07 into python-poetry:master May 17, 2022
@dimbleby dimbleby deleted the fix-5103 branch May 17, 2022 17:28
@kasteph kasteph mentioned this pull request May 30, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry init -n causes crashes on poetry >= 1.2.0a2
2 participants