Use flake8-pie

[AlpAribal]

Relates-to: #4776

Adding the hook leads to four new warnings for the repo. Each warning was handled in a separate commit.

• PIE781: assign-and-return
  All instances of this warning were fixed [Edit: This warning is ignored altogether as it does not play well with mypy and there is not 100% agreement with the enforced style.]
• PIE803: prefer-logging-interpolation
  This check produces false positives (debug() calls are always flagged as if they belong to a logger). PR ignores such instances and fixes the rest.
• PIE786: precise-exception-handlers
  PR ignores instances where the intention is indeed to catch any exceptions and fixes the rest.
• PIE798: no-unnecessary-class
  All instances are ignored via an additional entry in flake8 config.

I am aware that some ignore/fix decisions can be considered opinionated, and am happy to make changes where necessary.

[dimbleby]

as the pipelines are showing you, pie781 is at odds with appeasing mypy. IMO it's more important that mypy be happy.

(I believe that there's work going on to improve the typing eg in cleo, so perhaps we'll one day be able to avoid the mypy-appeasement and just write the code more naturally)

[AlpAribal]

as the pipelines are showing you, pie781 is at odds with appeasing mypy. IMO it's more important that mypy be happy.

How would you recommend tackling this issue? Should I ignore pie781 for good or ignore mypy type warnings for these cases?

[dimbleby]

How would you recommend tackling this issue?

I don't much mind either way. The main thing is that I think that the mypy checking is valuable, so making that happy should 'win'.

Personally I rather like the style that pie781 objects to so I'd probably suppress it altogether, but this is certainly a matter of taste.

If you think it's generally a valuable warning then I guess ignore it explicitly in the places where we have deliberately gone against it for the purpose of typechecking.

[AlpAribal]

Personally I rather like the style that pie781 objects to so I'd probably suppress it altogether, but this is certainly a matter of taste.

I see, I do not have a strong preference either. I will ignore the warning.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.