Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not every GroupCommand needs to be an EnvCommand #6282

Merged

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Aug 31, 2022

Relating to #6275 and python-poetry/poetry-plugin-export#78

Not every GroupCommand needs to be an EnvCommand (though it's true that every GroupCommand in this repository is also an EnvCommand, so this refactoring changes nothing here).

The intention is to make a change to the export plugin so that the ExportCommand can be a GroupCommand but not an EnvCommand: it does need access to the group options, but it does not need a virtual environment.

@dimbleby dimbleby force-pushed the disentangle-env-command-somewhat branch from 48cbfb7 to 0fc1e3b Compare August 31, 2022 11:19
@dimbleby
Copy link
Contributor Author

Arguably not every InstallerCommand should need to be an EnvCommand eg SelfCommand shouldn't, per #6225. Perhaps an improved version of that fix would be to take EnvCommand off the InstallerCommand and add it back only on the commands that actually need it.

Another day, maybe...

@dimbleby
Copy link
Contributor Author

actually let's do that while we're here, you can always reject the second commit if it's too much

@dimbleby
Copy link
Contributor Author

ugh no, the SelfCommand is messier than I thought, let's just do the one thing after all.

@dimbleby dimbleby force-pushed the disentangle-env-command-somewhat branch from cead246 to 0fc1e3b Compare August 31, 2022 11:35
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants