-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Informative UploadError
#7004
base: main
Are you sure you want to change the base?
Fix: Informative UploadError
#7004
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this use exception chaining instead of doubling down on string-based handling.
@neersighted I am not clear on what you want by using exception chaining. I've brought some examples of libraries by pypa to observe actions in case of network failure. Are you saying you want
|
Let's merge this |
Pull Request Check List
Resolves: #3813
When
UploadError
is raised due torequests.ConnectionError
, the error message is a fixed general recommendation. The error itself is not shown to the user, making it hard for the user to debug the problem.This PR fixes the problem by adding the representation of the exception to the error message.