Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set package pretty_version #7305

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Jan 5, 2023

The pretty_version on the Package is pointless, it can always just be taken from the regular version's .text.

This is the only place in the codebase that sets it; and clearly it's not doing anything useful.

This is a prelude to corresponding tidying in poetry-core

@dimbleby
Copy link
Contributor Author

dimbleby commented Jan 5, 2023

test failure looks spurious:

      � Installing cleo (0.6.5)
  +   � Installing tomlkit (0.5.5)
      � Installing pendulum (1.4.4)
  -   � Installing tomlkit (0.5.5)
      � Installing demo (0.1.2 9cf87a2)

hard to believe that this MR changes that but only on Windows 3.10

(also this is clearly an over-specified test, though I'm not proposing to do anything about that since I assume the problem will go away on retry)

@radoering radoering merged commit 33b8b5a into python-poetry:master Jan 22, 2023
@dimbleby dimbleby deleted the no-pretty-version branch January 22, 2023 14:06
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants