debug ci test failures #7784
Merged
debug ci test failures #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
force-pushed
the
debug-ci-failures
branch
2 times, most recently
from
ec618a9
to
c0f375e
Compare
dimbleby
force-pushed
the
debug-ci-failures
branch
from
c0f375e
to
3b84a52
Compare
dimbleby
force-pushed
the
debug-ci-failures
branch
from
3b84a52
to
6407c1e
Compare
radoering
approved these changes
Apr 11, 2023
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I've seen the changed testcase failing, rarely, in CI.
It's a bit of a curious testcase because so far as I can see it should only ever go through the branch that I've retained - as previously structured the output was quite unhelpful on failure (
venv.run()gets called two times, instead of three, in the examples I recall).So I've rearranged that, and also included information from the original exception in the
PackageInfoErrorwhich - I think - must be the one that is being hit. The hope being that next time the test fails, we'll get to see what the problem was.I speculate that this might be #7611 being hit in poetry's own CI pipelines all along.
However obviously now that I want the test script to fail, it is passing reliably, I've tried a few times and not hit problems...
Might just as well merge this though I think - it improves the clarity of the scripts anyway, and probably sooner or later it will pay off and reveal something.