Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warning about disabling PyPI become true and deprecate default source #8771

Merged
merged 2 commits into from Jan 27, 2024

Conversation

radoering
Copy link
Member

Pull Request Check List

Continues #7801 (see target image in issue description)

  • Added tests for changed code.
  • Updated documentation for changed code.

If there is a primary source, no default source and PyPI is not configured explicitly, we print the following warning since Poetry 1.5:

"Warning: In a future version of Poetry, PyPI will be disabled"
" automatically if at least one custom primary source is"
" configured. In order to avoid"
" a breaking change and make your pyproject.toml forward"
" compatible, add PyPI explicitly via 'poetry source add pypi'."
" By the way, this has the advantage that you can set the"
" priority of PyPI as with any other source."

Since we are printing it for three versions now, I suppose we can consider to make this warning become true. When we do that, the priority default is the same as the topmost primary source (if there is no default source). Thus, we can deprecate default to make source priorities simpler.

@radoering radoering added the impact/docs Contains or requires documentation changes label Dec 9, 2023
Copy link

github-actions bot commented Dec 9, 2023

Deploy preview for website ready!

✅ Preview
https://website-r2z49ej5y-python-poetry.vercel.app

Built with commit 59e2ebe.
This pull request is being automatically deployed with vercel-action

@radoering radoering marked this pull request as ready for review December 9, 2023 13:58
@radoering radoering mentioned this pull request Dec 22, 2023
@radoering radoering merged commit 1df6f53 into python-poetry:master Jan 27, 2024
33 checks passed
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants