Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: consider explicit source when searching for a locked package with a source reference in the repository pool #8948

Conversation

radoering
Copy link
Member

@radoering radoering commented Feb 5, 2024

Pull Request Check List

Resolves: #8928

  • Added tests for changed code.
  • Updated documentation for changed code.

1st commit: naive approach

  • fixes first test added in test_provider
  • breaks second and third test added in test_provider (which both succed without the change)

2nd commit: more sophisticated, robust approach

@radoering radoering mentioned this pull request Feb 5, 2024
@radoering radoering force-pushed the provider-complete-locked-package-explicit branch from f307fcb to 0f60f53 Compare February 5, 2024 17:06
@radoering radoering marked this pull request as draft February 6, 2024 05:01
@radoering radoering force-pushed the provider-complete-locked-package-explicit branch 2 times, most recently from eca230c to d7c44c5 Compare February 9, 2024 16:41
@radoering radoering marked this pull request as ready for review February 9, 2024 16:46
@radoering radoering force-pushed the provider-complete-locked-package-explicit branch from d7c44c5 to de0ac10 Compare February 11, 2024 12:22
@radoering radoering force-pushed the provider-complete-locked-package-explicit branch from de0ac10 to 0520cf3 Compare February 13, 2024 16:30
@radoering radoering merged commit 5f75fdd into python-poetry:master Feb 13, 2024
20 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry update removes explicit source from lockfile unexpectedly
2 participants