Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: state a limitation of develop attribute #8971

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Docs: state a limitation of develop attribute #8971

merged 3 commits into from
Feb 16, 2024

Conversation

bersbersbers
Copy link
Contributor

Resolves: #8965

@bersbersbers bersbersbers mentioned this pull request Feb 14, 2024
Closed
4 tasks
@dimbleby
Copy link
Contributor

dimbleby commented Feb 14, 2024 •
edited
Loading

I would guess that this will confuse more people than it helps!

Edit to expand on that...

More accurate would be to say something along the lines of this setting being effective only when using poetry install.

Whether poetry-core understands this field or not is essentially irrelevant. The issue is whether there is any way for poetry-core (or any backend) to tell the front-end that it would like a particular dependency to be installed in editable mode. There is not.

Therefore this only works when using poetry itself, which does understand poetry-specific configuration.

radoering
radoering reviewed Feb 15, 2024
View reviewed changes
docs/cli.md Outdated Show resolved Hide resolved
@radoering radoering changed the title Docs: state a limitation of Poetry Core Docs: state a limitation of develop attribute Feb 16, 2024
bersbersbers and others added 3 commits February 16, 2024 16:47
@bersbersbers @radoering
State limitation of Poetry Core
775565e 
Closes #8965
@bersbersbers @radoering
Reformulate as a function of poetry install
8d523eb
@bersbersbers @radoering
Accept suggestion
9868af3 
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
@radoering radoering added the impact/docs Contains or requires documentation changes label Feb 16, 2024
@github-actions GitHub Actions
Copy link

Deploy preview for website ready!

✅ Preview
https://website-q4whgysjk-python-poetry.vercel.app

Built with commit 9868af3.
This pull request is being automatically deployed with vercel-action

@radoering radoering merged commit 9165843 into python-poetry:master Feb 16, 2024
20 checks passed
@radoering radoering mentioned this pull request Feb 17, 2024
Merged
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

poetry-core does not install local dependency in editable mode
3 participants
@bersbersbers @dimbleby @radoering