Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash metadata as bytes #9049

Merged
merged 3 commits into from Mar 2, 2024
Merged

Hash metadata as bytes #9049

merged 3 commits into from Mar 2, 2024

Commits on Mar 2, 2024

  1. Just hash metadata as bytes. 

    Because warehouse doesn't send a charset, this can get decoded as something
other than utf-8, which doesn't encode (as utf-8) back to the same bytes.  For
hash purposes especially, just look at the original bytes.
    @thatch @radoering
    thatch authored and radoering committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    cf1d0c5 View commit details
    Browse the repository at this point in the history

  2. Modify isort-metadata test to be invalid utf-8 

    This ensures that it remains bytes the whole way through.
    @thatch @radoering
    thatch authored and radoering committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    907ce93 View commit details
    Browse the repository at this point in the history

  3. Revert "Modify isort-metadata test to be invalid utf-8"

    @radoering
    radoering committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    4d9b071 View commit details
    Browse the repository at this point in the history