ci/release: implement trusted publishing #9237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now run GHA on tags.
abn
reviewed
Mar 25, 2024
neersighted
force-pushed
the
release_revamp
branch
from
26c425f
to
0cc195b
Compare
neersighted
force-pushed
the
release_revamp
branch
from
0cc195b
to
7bf175d
Compare
Completely rewrite the release workflow. There are a couple key differences now: * Releases are triggered by GitHub releases; which can refer to an existing tag, or create one on the fly. * Credentials are no longer needed to perform a release, instead we use the PyPI trusted publishing flow. * The build and upload tasks are split to ensure the credentials are safeguarded. * Uploads require approval from one other maintainer (beyond the person who triggered the build). Note that PyPI will only accept uploads from the 'pypi' environment, triggered in this workflow file.
neersighted
force-pushed
the
release_revamp
branch
from
7bf175d
to
b66198d
Compare
abn
reviewed
Mar 25, 2024
abn
approved these changes
Mar 25, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely rewrite the release workflow. There are a couple key differences now:
Note that PyPI will only accept uploads from the 'pypi' environment, triggered in this workflow file.