Remove fish --init-command, fixes #9463

[phette23]

Don't use --init-command when starting a fish venv subshell, instead treat it as other shells. The --init--command doesn't work well with python managed by mise. This has an added bonus of removing a few lines of code and some special handling for fish that doesn't seem to be necessary.

Pull Request Check List

Resolves: #9463

I'm not sure where the tests are for Shell but I'm happy to look at writing some for this. It's tricky because the bug being addressed is only for a specific environment (mise and fish shell). What I did to confirm was:

> poetry install # make a venv
> poetry shell
> which -a python
/path/to/global/mise/python
/path/to/venv/python
> # apply patch
> poetry shell
> which -a python
/path/to/venv/python
/path/to/global/mise/python

Hopefully the issue and testing its solution is clear from the issue I submitted.

[dimbleby]

#8804

[phette23]

Yeah this basically reverts #8804 😔 it is nice to not have the extra source line as described in that PR but poetry shell isn't working for me with --init-command.

[radoering]

@MrGreenTea Maybe, you have an opinion/idea since you contributed #8804.

[MrGreenTea]

@radoering thanks for notifying me.

I'd love to take a look at this. To me it seems this is more a weird behaviour by mise than an issue with poetry. Reversing this feature seems a workaround for that problem which I would love to take a look next week if it's not too urgent :)