Merge pull request #126 from stlehmann/altendky-patch-3

QtCore.QCoreApplication.instance() may return None
python-qt-tools · Dec 31, 2020 · 6630551 · 6630551
2 parents e9a2f2d + fd2e1e6
commit 6630551
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 * [#51](https://github.com/stlehmann/PyQt5-stubs/pull/51) adds `pyqtBoundSignal.signal` hinted as `str`
 
 ### Changed
+* [#126](https://github.com/stlehmann/PyQt5-stubs/pull/126) fix `QCoreApplication.instance()` return type to be optional
 * [#102](https://github.com/stlehmann/PyQt5-stubs/pull/102) fix `pyqtSlot` parameter typing and overloads
 * [#104](https://github.com/stlehmann/PyQt5-stubs/pull/104) `sip.voidptr` handles integer values and sequences and takes `self`
 * [#103](https://github.com/stlehmann/PyQt5-stubs/pull/103) `pyqtBoundSignal.disconnect()`'s `slot` parameter is optional

diff --git a/PyQt5-stubs/QtCore.pyi b/PyQt5-stubs/QtCore.pyi
@@ -3020,7 +3020,7 @@ class QCoreApplication(QObject):
     @staticmethod
     def exec_() -> int: ...
     @staticmethod
-    def instance() -> 'QCoreApplication': ...
+    def instance() -> typing.Optional['QCoreApplication']: ...
     @staticmethod
     def arguments() -> typing.List[str]: ...
     @staticmethod