Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyqtBoundSignal.disconnect()'s slot parameter is optional #103

Merged
merged 3 commits into from Oct 4, 2020
Merged

pyqtBoundSignal.disconnect()'s slot parameter is optional #103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f574814
`pyqtBoundSignal.disconnect()`'s `slot` parameter is optional
altendky Oct 4, 2020
27eef83
Update PyQt5-stubs/QtCore.pyi
altendky Oct 4, 2020
2fc7c46
Merge branch 'master' into pyqtBoundSignal_disconnect_optional
altendky Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* [#51](https://github.com/stlehmann/PyQt5-stubs/pull/51) adds `pyqtBoundSignal.signal` hinted as `str`

### Changed
* [#103](https://github.com/stlehmann/PyQt5-stubs/pull/103) `pyqtBoundSignal.disconnect()`'s `slot` parameter is optional
* [#92](https://github.com/stlehmann/PyQt5-stubs/pull/92) remove self from `qDefaultSurfaceFormat()` and `qIdForNode()`
* [#83](https://github.com/stlehmann/PyQt5-stubs/pull/83) fixes `sip.array` to be generic
* [#79](https://github.com/stlehmann/PyQt5-stubs/pull/79) fixes extra class layer in several modules
Expand Down
2 changes: 1 addition & 1 deletion PyQt5-stubs/QtCore.pyi
View file
Open in desktop
Expand Up @@ -35,7 +35,7 @@ class pyqtBoundSignal:

def emit(self, *args: typing.Any) -> None: ...
def connect(self, slot: "PYQT_SLOT") -> "QMetaObject.Connection": ...
def disconnect(self, slot: typing.Union["PYQT_SLOT", "QMetaObject.Connection"]=None) -> None: ...
def disconnect(self, slot: typing.Optional[typing.Union["PYQT_SLOT", "QMetaObject.Connection"]]=None) -> None: ...
altendky marked this conversation as resolved.
Show resolved Hide resolved


class pyqtSignal:
Expand Down