Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct annotations for signals in QThread and QNetworkAccessManager #129

Merged
merged 2 commits into from Feb 16, 2021
Merged

Correct annotations for signals in QThread and QNetworkAccessManager #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8e0a2b
Corrected annotations for signal in QThread and QNetworkAccessManager
Jan 6, 2021
9ee8150
Added changelog entry. Added annotation for deprecated signal QNetwor…
Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
* [#51](https://github.com/stlehmann/PyQt5-stubs/pull/51) adds `pyqtBoundSignal.signal` hinted as `str`

### Changed
* [#129](https://github.com/stlehmann/PyQt5-stubs/pull/129) fixes `QThread` and `QNetworkAccessManager` signals
* [#109](https://github.com/stlehmann/PyQt5-stubs/pull/109) `.__or__()` for `QMessageBox.StandardButton` and `QMessageBox.StandardButtons`
* [#126](https://github.com/stlehmann/PyQt5-stubs/pull/126) fix `QCoreApplication.instance()` return type to be optional
* [#102](https://github.com/stlehmann/PyQt5-stubs/pull/102) fix `pyqtSlot` parameter typing and overloads
Expand Down
4 changes: 2 additions & 2 deletions PyQt5-stubs/QtCore.pyi
View file
Open in desktop
Expand Up @@ -8247,8 +8247,8 @@ class QThread(QObject):
def exec(self) -> int: ...
def exec_(self) -> int: ...
def run(self) -> None: ...
def finished(self) -> None: ...
def started(self) -> None: ...
finished: typing.ClassVar[pyqtSignal]
started: typing.ClassVar[pyqtSignal]
@typing.overload
def wait(self, msecs: int = ...) -> bool: ...
@typing.overload
Expand Down
14 changes: 7 additions & 7 deletions PyQt5-stubs/QtNetwork.pyi
View file
Open in desktop
Expand Up @@ -764,13 +764,13 @@ class QNetworkAccessManager(QtCore.QObject):
def setProxyFactory(self, factory: 'QNetworkProxyFactory') -> None: ...
def proxyFactory(self) -> 'QNetworkProxyFactory': ...
def createRequest(self, op: 'QNetworkAccessManager.Operation', request: 'QNetworkRequest', device: typing.Optional[QtCore.QIODevice] = ...) -> 'QNetworkReply': ...
def preSharedKeyAuthenticationRequired(self, reply: 'QNetworkReply', authenticator: 'QSslPreSharedKeyAuthenticator') -> None: ...
def networkAccessibleChanged(self, accessible: 'QNetworkAccessManager.NetworkAccessibility') -> None: ...
def sslErrors(self, reply: 'QNetworkReply', errors: typing.Iterable['QSslError']) -> None: ...
def encrypted(self, reply: 'QNetworkReply') -> None: ...
def finished(self, reply: 'QNetworkReply') -> None: ...
def authenticationRequired(self, reply: 'QNetworkReply', authenticator: QAuthenticator) -> None: ...
def proxyAuthenticationRequired(self, proxy: 'QNetworkProxy', authenticator: QAuthenticator) -> None: ...
preSharedKeyAuthenticationRequired = typing.ClassVar[QtCore.pyqtSignal]
networkAccessibleChanged = typing.ClassVar[QtCore.pyqtSignal]
sslErrors: typing.ClassVar[QtCore.pyqtSignal]
encrypted: typing.ClassVar[QtCore.pyqtSignal]
finished: typing.ClassVar[QtCore.pyqtSignal]
authenticationRequired: typing.ClassVar[QtCore.pyqtSignal]
proxyAuthenticationRequired: typing.ClassVar[QtCore.pyqtSignal]
@typing.overload
def put(self, request: 'QNetworkRequest', data: QtCore.QIODevice) -> 'QNetworkReply': ...
@typing.overload
Expand Down