Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict for mypy #99

Merged
merged 8 commits into from Oct 7, 2020
Merged

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Oct 3, 2020

@altendky altendky marked this pull request as draft October 3, 2020 02:08
@altendky
Copy link
Collaborator Author

altendky commented Oct 3, 2020

PyQt5-stubs/sip.pyi:82: error: Missing type parameters for generic type "array"

https://github.com/altendky/PyQt5-stubs/blob/a42d41d2400d845db0557ad3f621fde42ce5dd30/PyQt5-stubs/sip.pyi#L82

# The voidptr type.
class voidptr:
    <snip>
    def asarray(self, size: int = -1) -> array: ...

PyQt5-stubs/QtCore.pyi:9235: error: Missing type parameters for generic type "typing.Callable"

https://github.com/altendky/PyQt5-stubs/blob/a42d41d2400d845db0557ad3f621fde42ce5dd30/PyQt5-stubs/QtCore.pyi#L9235

FuncT = typing.TypeVar('FuncT', bound=typing.Callable)  # For a correct pyqtSlot annotation

https://github.com/altendky/PyQt5-stubs/blob/a42d41d2400d845db0557ad3f621fde42ce5dd30/PyQt5-stubs/QtCore.pyi#L9267

def pyqtSlot(*types: typing.Any, name: typing.Optional[str] = ..., result: typing.Optional[str] = ...) -> typing.Callable[[FuncT], FuncT]: ...

@altendky altendky changed the title Strict for mypy and related cleanup Enable strict for mypy Oct 4, 2020
@altendky altendky marked this pull request as ready for review October 7, 2020 23:15
@altendky altendky merged commit 811462b into python-qt-tools:master Oct 7, 2020
@altendky altendky deleted the tighten_mypy branch October 7, 2020 23:20
bluebird75 pushed a commit to bluebird75/PyQt5-stubs that referenced this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants