New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail with Python 3.8 #125
Comments
… instances In Python 3.8 they removed several __str__() implementations (see commit python/cpython@96aeaec), so under that version calling str() on an IntEnum instance gives something like "<EnumName.attr: 123>", not the literal integer value as before, so the right thing, that seems to work also on Python 3.7, is to use repr() instead. This fixes issue #125.
This seems to fix the issue, at least for 3.7 and 3.8... let's see. |
Will there be a bugfix release soon or should we cherrypick the mentioned patch? |
I could easily make a release if you are in a hurry: I was waiting for pypa/cibuildwheel#172... |
All fine. Cherry-picked aa16ff9 ... it now build+tests fine with Python 3.6, 3.7, 3.8 (on linux64, osx64, win64) :) |
I released version 0.9.0 that includes this fix. |
Failure is persistent with Python 3.8 on linux/osx/win (64bit):
See also conda-forge/python-rapidjson-feedstock#21
The text was updated successfully, but these errors were encountered: