Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recursive models #174

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add support for recursive models #174

merged 1 commit into from
Jul 28, 2020

Conversation

peterjwest
Copy link
Contributor

@peterjwest peterjwest commented Jul 14, 2020

This is a port of noirbizarre/flask-restplus#656
It should resolve #110

Thanks to @buggyspace, @Drarok and @edwardfung123 for identifying and fixing this.

I've followed the CONTRIBUTING.rst file, but couldn't locate the changelog to add this change, is this out of date?

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #174 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          19       19           
  Lines        2695     2697    +2     
=======================================
+ Hits         2612     2614    +2     
  Misses         83       83           
Impacted Files Coverage Δ
flask_restx/swagger.py 96.74% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c08b1...415b90c. Read the comment docs.

@peterjwest
Copy link
Contributor Author

@ziirish is there any chance you could review this?

ziirish
ziirish previously approved these changes Jul 15, 2020
Copy link
Contributor

@ziirish ziirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziirish
Copy link
Contributor

ziirish commented Jul 15, 2020

Thanks for your contribution!

We don't have a Changelog anymore.
We try to summarize the changes while making a new release based on the commit history.

@peterjwest
Copy link
Contributor Author

Does this need to be rebased before it can be merged?

@j5awry
Copy link
Contributor

j5awry commented Jul 23, 2020

@peterjwest yes, if you could give this a rebase. I'm giving my +1 as well, so we'll be able to merge after rebase.

j5awry
j5awry previously approved these changes Jul 23, 2020
@peterjwest peterjwest dismissed stale reviews from j5awry and ziirish via 415b90c July 23, 2020 13:48
@peterjwest
Copy link
Contributor Author

@j5awry done

@j5awry j5awry merged commit 66d884f into python-restx:master Jul 28, 2020
@peterjwest peterjwest deleted the featured/recursive-model branch July 28, 2020 14:21
@Drarok Drarok mentioned this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for recursive nested models
3 participants