Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed implementation for Enum Field #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaesivsm
Copy link

Related to #79

what I haven't done

  • IntEnum
  • assertions on Enum values from typed Enum (only strings, only integers)
  • documentation, I didn't find the place where every type are explained with and example. If there's one I'd gladly add documentation about that field.

@j5awry j5awry mentioned this pull request Mar 16, 2020
@j5awry
Copy link
Contributor

j5awry commented Mar 16, 2020

Using the ticket for a higher level discussion of enum implementation. Please toggle back to #79 to see general comments.

Also be sure to check the CONTRIBUTING.md. We'd expect tests to be added for the addition.

@ziirish ziirish force-pushed the master branch 2 times, most recently from 0db7d06 to 4eaf373 Compare November 1, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants