Use context manager for open()

python-rope · Apr 27, 2020 · b4c49e5 · b4c49e5
1 parent 0385adb
commit b4c49e5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/rope/base/libutils.py b/rope/base/libutils.py
@@ -35,6 +35,7 @@ def path_to_resource(project, path, type=None):
 def path_relative_to_project_root(project, path):
     return relative(project.address, path)
 
+
 @utils.deprecated()
 def relative(root, path):
     root = rope.base.project._realpath(root).replace(os.path.sep, '/')

diff --git a/ropetest/advanced_oi_test.py b/ropetest/advanced_oi_test.py
@@ -696,9 +696,9 @@ def test_call_function_and_parameters(self):
     def test_report_change_in_libutils(self):
         self.project.prefs['automatic_soa'] = True
         code = 'class C(object):\n    pass\ndef f(p):\n    pass\nf(C())\n'
-        mod_file = open(self.mod.real_path, 'w')
-        mod_file.write(code)
-        mod_file.close()
+        with open(self.mod.real_path, 'w') as mod_file:
+            mod_file.write(code)
+
         rope.base.libutils.report_change(self.project, self.mod.real_path, '')
         pymod = self.project.get_pymodule(self.mod)
         c_class = pymod['C'].get_object()