Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform signature verification on pickled data transferred over sockets #251

Merged
merged 4 commits into from
Aug 8, 2018

Commits on Aug 6, 2018

  1. Perform signature verification on pickled data transferred over sockets

    Before unpickling anything, ensure that it has a valid digital
    signature using a randomly-generated shared key. In order for an attacker
    to send or tamper with data on the same socket, they must know this key
    to compute a valid signature.
    soupytwist committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    ea501c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Code review comments

    - Bind to localhost instead of 127.0.0.1
    - Update key generation method
    - Import cPickle if available
    soupytwist committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    52037a9 View commit details
    Browse the repository at this point in the history
  2. More code review changes

    - remove redundant call to bytes
    - use hmac.compare_digest
    soupytwist committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    1990049 View commit details
    Browse the repository at this point in the history
  3. More code review changes

    - Document _compat_compare_digest
    soupytwist committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    dc66284 View commit details
    Browse the repository at this point in the history