Refactor for testing and introduce pytest workflow #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
setup_github_actions
branch
4 times, most recently
from
5a39819
to
842feda
Compare
eivindjahren
force-pushed
the
setup_github_actions
branch
from
842feda
to
6316e4a
Compare
eivindjahren
force-pushed
the
setup_github_actions
branch
from
6316e4a
to
a5d1f5d
Compare
eivindjahren
force-pushed
the
setup_github_actions
branch
from
a5d1f5d
to
4d5d455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is admittedly a big PR, and I appologize.
I wanted to do the same change of setup as in python-rope/ropemode#21 where pytest and github actions are introduced. However, ropevim do have any tests (!) so I started refactoring the code in order to be able to test it. It ended up being a rather large refactoring.
Because ftplugin is changed, there will have to be a release to pypi rather quickly after merging the PR. This is because plugin managers fetch from main so anyone attempting to install ropevim will have incompatible versions until they run
pip install --upgrade ropevim. I have therefore taken the liberty of bumping the version and creating an error message to help people upgrade the ropevim pip package.