Add f-strings to label visitor #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHock
approved these changes
Jul 13, 2018
pyt/helper_visitors/label_visitor.py
Outdated
| def visit_FormattedValue(self, node): | ||
| self.result += '{' | ||
| self.visit(node.value) | ||
| self.result += { |
There was a problem hiding this comment.
Nit: Maybe add a comment for the formatting
self.result += {
-1: '', # no formatting
97: '!a', # ascii formatting
114: '!r', # repr formatting
115: '!s', # string formatting
}[node.conversion]
pyt/helper_visitors/label_visitor.py
Outdated
| self.result += "'" | ||
|
|
||
| def visit_FormattedValue(self, node): | ||
| self.result += '{' |
There was a problem hiding this comment.
Nit: Maybe add abstract grammar docstrings, I have started to do this recently.
e.g.
"""
JoinedStr(expr* values)
""""""
FormattedValue(expr value, int? conversion, expr? format_spec)
"""
Node types FormattedValue and JoinedStr were added in python 3.6.
|
Comments added as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node types
FormattedValueandJoinedStrwere added in python 3.6.