Skip to content

Commit

Permalink
fix(history): Fix level id's in angular parser
Browse files Browse the repository at this point in the history
  • Loading branch information
relekang committed Aug 18, 2015
1 parent 7bd0916 commit 2918d75
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions semantic_release/history/parser_angular.py
Expand Up @@ -36,18 +36,18 @@ def parse_commit_message(message):
)

parsed = re_parser.match(message)
level_bump = 4
level_bump = 0
if parsed.group('body') and 'BREAKING CHANGE' in parsed.group('body'):
level_bump = 1
level_bump = 3

if parsed.group('footer') and 'BREAKING CHANGE' in parsed.group('footer'):
level_bump = 1
level_bump = 3

if parsed.group('type') == 'feat':
level_bump = min([level_bump, 2])
level_bump = max([level_bump, 2])

if parsed.group('type') == 'fix':
level_bump = min([level_bump, 2])
level_bump = max([level_bump, 1])

return (
level_bump,
Expand Down
10 changes: 5 additions & 5 deletions tests/test_parsers.py
Expand Up @@ -16,16 +16,16 @@ def test_parser_raises_unknown_message_style(self):
def test_parser_return_correct_bump_level(self):
self.assertEqual(
angular_parser('feat(parsers): Add new parser pattern\n\nBREAKING CHANGE:')[0],
1
3
)
self.assertEqual(
angular_parser('feat(parsers): Add new parser pattern\n\n'
'New pattern is awesome\n\nBREAKING CHANGE:')[0],
1
3
)
self.assertEqual(angular_parser('feat(parser): Add emoji parser')[0], 2)
self.assertEqual(angular_parser('fix(parser): Fix regex in angular parser')[0], 2)
self.assertEqual(angular_parser('test(parser): Add a test for angular parser')[0], 4)
self.assertEqual(angular_parser('fix(parser): Fix regex in angular parser')[0], 1)
self.assertEqual(angular_parser('test(parser): Add a test for angular parser')[0], 0)

def test_parser_return_type_from_commit_message(self):
self.assertEqual(angular_parser('feat(parser): ...')[1], 'feature')
Expand Down Expand Up @@ -58,7 +58,7 @@ def test_parser_return_subject_from_commit_message(self):

def test_parser_return_text_from_commit_message(self):
self.assertEqual(
angular_parser('fix(parser): Fix regex in angular parser\n\n{}'.format(self.text))[3][1],
angular_parser('fix(parser): Fix regex in an parser\n\n{}'.format(self.text))[3][1],
self.text
)

Expand Down

0 comments on commit 2918d75

Please sign in to comment.