fix: Add quotes around twine arguments

Fixes #163
python-semantic-release · Jan 18, 2020 · 46a83a9 · 46a83a9
1 parent 8a7ca61
commit 46a83a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/semantic_release/pypi.py b/semantic_release/pypi.py
@@ -27,7 +27,7 @@ def upload_to_pypi(
         run(f'rm -rf {path}')
     run('python setup.py {}'.format(dists))
     run(
-        'twine upload -u {} -p {} {} {}/*'.format(
+        "twine upload -u '{}' -p '{}' {} \"{}/*\"".format(
             username,
             password,
             '--skip-existing' if skip_existing else '',

diff --git a/tests/test_pypi.py b/tests/test_pypi.py
@@ -15,7 +15,7 @@ def test_upload_without_arguments(self, mock_run):
             [
                 mock.call('rm -rf dist'),
                 mock.call('python setup.py sdist bdist_wheel'),
-                mock.call('twine upload -u username -p password  dist/*'),
+                mock.call("twine upload -u 'username' -p 'password'  \"dist/*\""),
                 mock.call('rm -rf dist')
             ]
         )
@@ -27,7 +27,7 @@ def test_upload_without_removing_dist(self, mock_run):
             mock_run.call_args_list,
             [
                 mock.call('python setup.py sdist bdist_wheel'),
-                mock.call('twine upload -u username -p password  dist/*'),
+                mock.call("twine upload -u 'username' -p 'password'  \"dist/*\""),
             ]
         )
 
@@ -38,7 +38,8 @@ def test_upload_with_custom_path(self, mock_run):
         self.assertEqual(args[0], mock.call('rm -rf custom-dist'),)
         self.assertEqual(args[1], mock.call('python setup.py sdist bdist_wheel'),)
         self.assertEqual(args[2], mock.call(
-            'twine upload -u username -p password  custom-dist/*'),)
+            "twine upload -u 'username' -p 'password'  \"custom-dist/*\""),
+        )
         self.assertEqual(args[3], mock.call('rm -rf custom-dist'))
 
     def test_raises_error_when_missing_credentials(self):