Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate markdown linter compliant changelog headers & lists #597

Conversation

ringohoffman
Copy link
Contributor

In #594, I missed that there are 2 places where the version header is formatted, one with dates and one without.

In this PR, I add the extra newline to make the generated changelogs markdownlint compliant when the date is included in the header.

In python-semantic-release#594, I missed that there are 2 places where the version header is formatted
@ringohoffman
Copy link
Contributor Author

@bernardcooke53 does this look okay?

Copy link
Contributor

@bernardcooke53 bernardcooke53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - looks good to me

@bernardcooke53 bernardcooke53 merged commit cc87400 into python-semantic-release:master Jun 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants