Skip to content

Commit

Permalink
Merge pull request #402 from tomschr/compare-258
Browse files Browse the repository at this point in the history
Fix #258: Keep semver._deprecated.compare
  • Loading branch information
tomschr committed Apr 2, 2023
2 parents c40b6a4 + 47b49ca commit 5abeda6
Show file tree
Hide file tree
Showing 10 changed files with 83 additions and 709 deletions.
10 changes: 9 additions & 1 deletion CHANGELOG.rst
Expand Up @@ -21,7 +21,7 @@ This section covers the changes between major version 2 and version 3.
Version 3.0.0
=============

:Released: 2023-03-19
:Released: 2023-04-02
:Maintainer: Tom Schraitle


Expand Down Expand Up @@ -95,6 +95,14 @@ Deprecations
didn't cast many votes, the majority agreed to remove support for
Python 3.6.

* :pr:`402`: Keep :func:`semver.compare <semver._deprecated.compare>`.
Although it breaks consistency with module level functions, it seems it's
a much needed/used function. It's still unclear if we should deprecate
this function or not (that's why we use :py:exc:`PendingDeprecationWarning`).

As we don't have a uniform initializer yet, this function stays in the
:file:`_deprecated.py` file for the time being until we find a better solution. See :gh:`258` for details.


Features
--------
Expand Down
4 changes: 2 additions & 2 deletions docs/api.rst
Expand Up @@ -17,6 +17,8 @@ Deprecated Functions in :mod:`semver._deprecated`

.. automodule:: semver._deprecated

.. autofunction:: semver._deprecated.compare

.. autofunction:: semver._deprecated.bump_build

.. autofunction:: semver._deprecated.bump_major
Expand All @@ -27,8 +29,6 @@ Deprecated Functions in :mod:`semver._deprecated`

.. autofunction:: semver._deprecated.bump_prerelease

.. autofunction:: semver._deprecated.compare

.. autofunction:: semver._deprecated.deprecated

.. autofunction:: semver._deprecated.finalize_version
Expand Down

0 comments on commit 5abeda6

Please sign in to comment.