Should _comparator return NotImplemented instead of raising TypeError? #316
Labels
Bug
Error, flaw or fault to produce incorrect or unexpected results
Question
Unclear or open issue subject for debate
Release_3.x.y
Only for the major release 3
Projects
Situation
when comparing an incompatible type, the
Version
class raisesTypeError
(through the_comparator
decorator):From a semantic point of view this is correct.
Question
According to the NotImplemented documentation (emphasize by me):
Should we return
NotImplemented
instead of raisingTypeError
?@python-semver/reviewers @tlaferriere Thoughts? Concerns?
The text was updated successfully, but these errors were encountered: