Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #135, convert prerelease and build to string #140

Merged
merged 8 commits into from
Oct 2, 2019

Commits on Sep 29, 2019

  1. Fix python-semver#135, convert prerelease and build to string

    Creating VersionInfo(3, 2, 1, 1) succeeds, but fails later when comparing
    it with another VersionInfo instance (for example, v1 < v2):
    
    ```
        def split_key(key):
    >       return [convert(c) for c in key.split('.')]
    E       AttributeError: 'int' object has no attribute 'split'
    ```
    tomschr committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    196df65 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Force major, minor, and patch as int

    To allow VersionInfo(10) > VersionInfo('2') == True
    tomschr committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    2f5a68d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef9abb1 View commit details
    Browse the repository at this point in the history
  3. Simplify test case, thanks to Alexander

    Co-authored-by: Alexander Grund
    tomschr committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    d708dd7 View commit details
    Browse the repository at this point in the history
  4. Split test case and check types

    Co-authored-by: Alexander Grund
    tomschr committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    a611a73 View commit details
    Browse the repository at this point in the history
  5. Move assert line

    * Move assert line to test_should_be_able_to_use_strings_as_major_minor_patch
    * Add additional assert, comparing VersionInfo created
      with strings and with integers
    
    Co-authored-by: Alexander Grund
    tomschr committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    9361751 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Integrate tests from Alex, many thanks!

    Co-authored-by: Alexander Grund
    tomschr committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    45a1049 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db85106 View commit details
    Browse the repository at this point in the history