-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #135, convert prerelease and build to string #140
Merged
Merged
Commits on Sep 29, 2019
-
Fix python-semver#135, convert prerelease and build to string
Creating VersionInfo(3, 2, 1, 1) succeeds, but fails later when comparing it with another VersionInfo instance (for example, v1 < v2): ``` def split_key(key): > return [convert(c) for c in key.split('.')] E AttributeError: 'int' object has no attribute 'split' ```
Configuration menu - View commit details
-
Copy full SHA for 196df65 - Browse repository at this point
Copy the full SHA 196df65View commit details
Commits on Sep 30, 2019
-
Force major, minor, and patch as int
To allow VersionInfo(10) > VersionInfo('2') == True
Configuration menu - View commit details
-
Copy full SHA for 2f5a68d - Browse repository at this point
Copy the full SHA 2f5a68dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef9abb1 - Browse repository at this point
Copy the full SHA ef9abb1View commit details -
Simplify test case, thanks to Alexander
Co-authored-by: Alexander Grund
Configuration menu - View commit details
-
Copy full SHA for d708dd7 - Browse repository at this point
Copy the full SHA d708dd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a611a73 - Browse repository at this point
Copy the full SHA a611a73View commit details -
* Move assert line to test_should_be_able_to_use_strings_as_major_minor_patch * Add additional assert, comparing VersionInfo created with strings and with integers Co-authored-by: Alexander Grund
Configuration menu - View commit details
-
Copy full SHA for 9361751 - Browse repository at this point
Copy the full SHA 9361751View commit details
Commits on Oct 1, 2019
-
Integrate tests from Alex, many thanks!
Co-authored-by: Alexander Grund
Configuration menu - View commit details
-
Copy full SHA for 45a1049 - Browse repository at this point
Copy the full SHA 45a1049View commit details -
Configuration menu - View commit details
-
Copy full SHA for db85106 - Browse repository at this point
Copy the full SHA db85106View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.