Fix #344 Allow empty string for bump method #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomschr
added
Release_3.x.y
tomschr
force-pushed
the
feature/344-prerelease-build
branch
2 times, most recently
from
6e8231c
to
4b30940
Compare
OidaTiftla
pushed a commit
to OidaTiftla/python-semver
that referenced
this pull request
Feb 9, 2023
* Improve pyproject.toml
* Use setuptools
* Add metadata
* Taken approach from
https://godatadriven.com/blog/a-practical-guide-to-setuptools-and-pyproject-toml/
* Doc: Describe building of semver
* Correct small glitches
* Remove .travis.yml in MANIFEST.in (not needed anymore)
* Distinguish between Python3.6 and others in tox.ini
* Add skip_missing_interpreters option for tox.ini
* Add changelog entry
* GH Action:
* Upgrade setuptools and setuptools-scm
* Also test against 3.11.0-rc.2
OidaTiftla
pushed a commit
to OidaTiftla/python-semver
that referenced
this pull request
Feb 9, 2023
Fix python-semver#365: Improve pyproject.toml
tomschr
force-pushed
the
feature/344-prerelease-build
branch
from
4b30940
to
cc5d01f
Compare
tomschr
force-pushed
the
feature/344-prerelease-build
branch
2 times, most recently
from
c5e732b
to
f7cbf24
Compare
tomschr
force-pushed
the
feature/344-prerelease-build
branch
2 times, most recently
from
cecbe8a
to
b1a01cd
Compare
The methods .bump_prerelease() and .bump_build() allow now different types for the token argument: * A string. This was already allowed and default was "rc". If the string is empty, we get only the raised number (without the "rc" part). The number starts from 1. * None. Is the same as calling the method without any argument.
tomschr
force-pushed
the
feature/344-prerelease-build
branch
from
b1a01cd
to
f8a182f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods
.bump_prerelease('')and.bump_build('')generates a prerelease and build part without the token.